Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Next.js: only set next/future/image mocks from version 12.2 #20098

Merged
merged 2 commits into from
Dec 6, 2022
Merged

Next.js: only set next/future/image mocks from version 12.2 #20098

merged 2 commits into from
Dec 6, 2022

Conversation

yannbf
Copy link
Member

@yannbf yannbf commented Dec 6, 2022

Issue: N/A

What I did

The version check was wrong, given that Next.js only introduced next/future/image from version 12.2

How to test

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

@valentinpalkovic valentinpalkovic merged commit 6ae449f into next Dec 6, 2022
@valentinpalkovic valentinpalkovic deleted the fix/next-12-future-image branch December 6, 2022 06:56
@kylegach kylegach mentioned this pull request Dec 8, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valentinpalkovic valentinpalkovic valentinpalkovic approved these changes

Assignees
No one assigned
Labels
bug nextjs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yannbf @valentinpalkovic